Refactoring with Codemods to Automate API Modifications

Clear a Stale Function Toggle

Let’s begin with a easy but sensible instance to display the
energy of codemods. Think about you’re utilizing a function
toggle in your
codebase to regulate the discharge of unfinished or experimental options.
As soon as the function is reside in manufacturing and dealing as anticipated, the subsequent
logical step is to wash up the toggle and any associated logic.

As an example, think about the next code:

const knowledge = featureToggle('feature-new-product-list') ? { title: 'Product' } : undefined;

As soon as the function is absolutely launched and now not wants a toggle, this
could be simplified to:

const knowledge = { title: 'Product' };

The duty entails discovering all cases of featureToggle within the
codebase, checking whether or not the toggle refers to
feature-new-product-list, and eradicating the conditional logic surrounding
it. On the identical time, different function toggles (like
feature-search-result-refinement, which can nonetheless be in growth)
ought to stay untouched. The codemod must perceive the construction
of the code to use adjustments selectively.

Understanding the AST

Earlier than we dive into writing the codemod, let’s break down how this
particular code snippet appears to be like in an AST. You should use instruments like AST
Explorer to visualise how supply code and AST
are mapped. It’s useful to grasp the node sorts you are interacting
with earlier than making use of any adjustments.

The picture under exhibits the syntax tree when it comes to ECMAScript syntax. It
comprises nodes like Identifier (for variables), StringLiteral (for the
toggle title), and extra summary nodes like CallExpression and
ConditionalExpression.

Determine 2: The Summary Syntax Tree illustration of the function toggle examine

On this AST illustration, the variable knowledge is assigned utilizing a
ConditionalExpression. The take a look at a part of the expression calls
featureToggle('feature-new-product-list'). If the take a look at returns true,
the consequent department assigns { title: 'Product' } to knowledge. If
false, the alternate department assigns undefined.

For a job with clear enter and output, I favor writing checks first,
then implementing the codemod. I begin by defining a unfavorable case to
guarantee we don’t by accident change issues we wish to go away untouched,
adopted by an actual case that performs the precise conversion. I start with
a easy state of affairs, implement it, then add a variation (like checking if
featureToggle known as inside an if assertion), implement that case, and
guarantee all checks cross.

This strategy aligns properly with Check-Pushed Improvement (TDD), even
if you happen to don’t observe TDD frequently. Realizing precisely what the
transformation’s inputs and outputs are earlier than coding improves security and
effectivity, particularly when tweaking codemods.

With jscodeshift, you’ll be able to write checks to confirm how the codemod
behaves:

const remodel = require("../remove-feature-new-product-list");

defineInlineTest(
  remodel,
  {},
  `
  const knowledge = featureToggle('feature-new-product-list') ? { title: 'Product' } : undefined;
  `,
  `
  const knowledge = { title: 'Product' };
  `,
  "delete the toggle feature-new-product-list in conditional operator"
);

The defineInlineTest perform from jscodeshift lets you outline
the enter, anticipated output, and a string describing the take a look at’s intent.
Now, operating the take a look at with a traditional jest command will fail as a result of the
codemod isn’t written but.

The corresponding unfavorable case would make sure the code stays unchanged
for different function toggles:

defineInlineTest(
  remodel,
  {},
  `
  const knowledge = featureToggle('feature-search-result-refinement') ? { title: 'Product' } : undefined;
  `,
  `
  const knowledge = featureToggle('feature-search-result-refinement') ? { title: 'Product' } : undefined;
  `,
  "don't change different function toggles"
);

Writing the Codemod

Let’s begin by defining a easy remodel perform. Create a file
referred to as remodel.js with the next code construction:

module.exports = perform(fileInfo, api, choices) {
  const j = api.jscodeshift;
  const root = j(fileInfo.supply);

  // manipulate the tree nodes right here

  return root.toSource();
};

This perform reads the file right into a tree and makes use of jscodeshift’s API to
question, modify, and replace the nodes. Lastly, it converts the AST again to
supply code with .toSource().

Now we are able to begin implementing the remodel steps:

1. Discover all cases of featureToggle.
2. Confirm that the argument handed is 'feature-new-product-list'.
3. Change all the conditional expression with the consequent half,
   successfully eradicating the toggle.

Right here’s how we obtain this utilizing jscodeshift:

module.exports = perform (fileInfo, api, choices) {
  const j = api.jscodeshift;
  const root = j(fileInfo.supply);

  // Discover ConditionalExpression the place the take a look at is featureToggle('feature-new-product-list')
  root
    .discover(j.ConditionalExpression, {
      take a look at: {
        callee: { title: "featureToggle" },
        arguments: [{ value: "feature-new-product-list" }],
      },
    })
    .forEach((path) => {
      // Change the ConditionalExpression with the 'consequent'
      j(path).replaceWith(path.node.consequent);
    });

  return root.toSource();
};

The codemod above:

• Finds ConditionalExpression nodes the place the take a look at calls
  featureToggle('feature-new-product-list').
• Replaces all the conditional expression with the resultant (i.e., {
title: 'Product' }), eradicating the toggle logic and leaving simplified code
  behind.

This instance demonstrates how simple it’s to create a helpful
transformation and apply it to a big codebase, considerably decreasing
handbook effort.

You’ll want to jot down extra take a look at circumstances to deal with variations like
if-else statements, logical expressions (e.g.,
!featureToggle('feature-new-product-list')), and so forth to make the
codemod strong in real-world eventualities.

As soon as the codemod is prepared, you’ll be able to try it out on a goal codebase,
such because the one you are engaged on. jscodeshift gives a command-line
device that you need to use to use the codemod and report the outcomes.

$ jscodeshift -t transform-name src/

After validating the outcomes, examine that every one useful checks nonetheless
cross and that nothing breaks—even if you happen to’re introducing a breaking change.
As soon as happy, you’ll be able to commit the adjustments and lift a pull request as
a part of your regular workflow.

Codemods Enhance Code High quality and Maintainability

Codemods aren’t simply helpful for managing breaking API adjustments—they will
considerably enhance code high quality and maintainability. As codebases
evolve, they usually accumulate technical debt, together with outdated function
toggles, deprecated strategies, or tightly coupled elements. Manually
refactoring these areas could be time-consuming and error-prone.

By automating refactoring duties, codemods assist hold your codebase clear
and freed from legacy patterns. Usually making use of codemods lets you
implement new coding requirements, take away unused code, and modernize your
codebase with out having to manually modify each file.

Refactoring an Avatar Element

Now, let’s take a look at a extra complicated instance. Suppose you’re working with
a design system that features an Avatar element tightly coupled with a
Tooltip. Every time a consumer passes a title prop into the Avatar, it
mechanically wraps the avatar with a tooltip.

Determine 3: A avatar element with a tooltip

Right here’s the present Avatar implementation:

import { Tooltip } from "@design-system/tooltip";

const Avatar = ({ title, picture }: AvatarProps) => {
  if (title) {
    return (
      <Tooltip content material={title}>
        <CircleImage picture={picture} />
      </Tooltip>
    );
  }

  return <CircleImage picture={picture} />;
};

The purpose is to decouple the Tooltip from the Avatar element,
giving builders extra flexibility. Builders ought to be capable to determine
whether or not to wrap the Avatar in a Tooltip. Within the refactored model,
Avatar will merely render the picture, and customers can apply a Tooltip
manually if wanted.

Right here’s the refactored model of Avatar:

const Avatar = ({ picture }: AvatarProps) => {
  return <CircleImage picture={picture} />;
};

Now, customers can manually wrap the Avatar with a Tooltip as
wanted:

import { Tooltip } from "@design-system/tooltip";
import { Avatar } from "@design-system/avatar";

const UserProfile = () => {
  return (
    <Tooltip content material="Juntao Qiu">
      <Avatar picture="/juntao.qiu.avatar.png" />
    </Tooltip>
  );
};

The problem arises when there are a whole lot of Avatar usages unfold
throughout the codebase. Manually refactoring every occasion could be extremely
inefficient, so we are able to use a codemod to automate this course of.

Utilizing instruments like AST Explorer, we are able to
examine the element and see which nodes symbolize the Avatar utilization
we’re concentrating on. An Avatar element with each title and picture props
is parsed into an summary syntax tree as proven under:

Determine 4: AST of the Avatar element utilization

Writing the Codemod

Let’s break down the transformation into smaller duties:

• Discover Avatar utilization within the element tree.
• Verify if the title prop is current.
• If not, do nothing.
• If current:
• Create a Tooltip node.
• Add the title to the Tooltip.
• Take away the title from Avatar.
• Add Avatar as a toddler of the Tooltip.
• Change the unique Avatar node with the brand new Tooltip.

To start, we’ll discover all cases of Avatar (I’ll omit among the
checks, however you need to write comparability checks first).

defineInlineTest(
    { default: remodel, parser: "tsx" },
    {},
    `
    <Avatar title="Juntao Qiu" picture="/juntao.qiu.avatar.png" />
    `,
    `
    <Tooltip content material="Juntao Qiu">
      <Avatar picture="/juntao.qiu.avatar.png" />
    </Tooltip>
    `,
    "wrap avatar with tooltip when title is offered"
  );

Just like the featureToggle instance, we are able to use root.discover with
search standards to find all Avatar nodes:

root
  .discover(j.JSXElement, {
    openingElement: { title: { title: "Avatar" } },
  })
  .forEach((path) => {
    // now we are able to deal with every Avatar occasion
  });

Subsequent, we examine if the title prop is current:

root
  .discover(j.JSXElement, {
    openingElement: { title: { title: "Avatar" } },
  })
  .forEach((path) => {
    const avatarNode = path.node;

    const nameAttr = avatarNode.openingElement.attributes.discover(
      (attr) => attr.title.title === "title"
    );

    if (nameAttr) {
      const tooltipElement = createTooltipElement(
        nameAttr.worth.worth,
        avatarNode
      );
      j(path).replaceWith(tooltipElement);
    }
  });

For the createTooltipElement perform, we use the
jscodeshift API to create a brand new JSX node, with the title
prop utilized to the Tooltip and the Avatar
element as a toddler. Lastly, we name replaceWith to
change the present path.

Right here’s a preview of the way it appears to be like in
Hypermod, the place the codemod is written on
the left. The highest half on the best is the unique code, and the underside
half is the reworked outcome:

Determine 5: Run checks inside hypermod earlier than apply it to your codebase

This codemod searches for all cases of Avatar. If a
title prop is discovered, it removes the title prop
from Avatar, wraps the Avatar inside a
Tooltip, and passes the title prop to the
Tooltip.

By now, I hope it’s clear that codemods are extremely helpful and
that the workflow is intuitive, particularly for large-scale adjustments the place
handbook updates could be an enormous burden. Nonetheless, that is not the entire
image. Within the subsequent part, I’ll make clear among the challenges
and the way we are able to deal with these less-than-ideal points.